popovers: Close user popover when clicked on stream name. #18908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryanshridhar
force-pushed
the
Fix-UserPopover
branch
from
dd40584
to
4f63519
Compare
Earlier, when a user clicked on any stream name from the user_popover, the stream page would open in the background, but the user popover wouldn't close. Fixed it by explicitly binding it to a click handler, which closes the user popover before redirecting to stream page.
timabbott
force-pushed
the
Fix-UserPopover
branch
from
4f63519
to
8cd9fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to CZO conversation.
Added a minor commit to close the
user_popoveroverlay if a user clicks on any stream name.Earlier:
Now: