Move stream setting templates to stream settings folder #19309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timabbott
reviewed
Jul 19, 2021
static/js/stream_settings_ui.js
Outdated
| @@ -3,10 +3,10 @@ import _ from "lodash"; | |||
| import tippy from "tippy.js"; | |||
|
|
|||
| import render_unsubscribe_private_stream_modal from "../templates/confirm_dialog/confirm_unsubscribe_private_stream.hbs"; | |||
| import render_settings_stream_list from "../templates/stream_settings/settings_stream_list.hbs"; | |||
| import render_settings_stream_list_item from "../templates/stream_settings/settings_stream_list_item.hbs"; | |||
There was a problem hiding this comment.
Do we want to call these browse_streams_list and browse_streams_list_item? I think "browse streams" is a reasonable name within the "stream settings" namespace for the left side of "stream settings" just like have "stream_edit" / "stream_create" for the right side.
|
This looks great and makes the templates feel much more organized; I posted one comment on a naming choice that might be worth tweaking, and then we can merge this. |
Following changes are done to subscription_table_body.hbs: * Rename subscription_table_body.hbs to stream_settings_overlay.hbs, to have a uniform naming pattern for stream settings templates. * Move it to stream_settings folder.
We do following changes to two small independet templates used in stream_settings area: * Move subscription_setting_icon.hbs to stream settings folder to have a consistent folder structure for stream settings templates. * Rename `subscription_count.hbs` to `subscriber_count.hbs`. * Move `subscriber_count.hbs` to `stream_settings` folder.
We move templates related to listing streams in left pannel of stream settings overlay to stream_settings folder by making following changes: * Rename `subscriptions.hbs` to `browse_streams_list.hbs`. * Move `settings_stream_list.hbs` to stream_settings folder. * Rename `subscription.hbs` to `browse_streams_list_item.hbs`. * Move `settings_stream_list_item.hbs` to stream_settings folder.
This commit moves stream_subscription_request_result.hbs to stream_settings folder to have a consistent file structure for stream setting templates.
|
Merged, thanks @m-e-l-u-h-a-n! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate stream setting templates to a separate
stream_settingsfolder.Follow up for: #19156.