message_edit: Replace checkboxes with settings_checkbox partial.
#19338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits replaces the custom `send_notification` message_edit checkboxes with our `settings_checkbox` partial. The main intention is to also support the feature of selecting a checkbox by clicking over its corresponding label as we have in the case of the organization settings checkboxes. Due to above change, this commit also removes the redundant `break-row` HTML class along with it styles.
aryanshridhar
force-pushed
the
Add-MsgEditLabelClick
branch
from
89bd153
to
85fd110
Compare
aryanshridhar
changed the title
settings_checkbox partial.
|
Merged, thanks @aryanshridhar! Can you check that we don't have the same bug in the "Move topic" widget? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CZO conversation: https://chat.zulip.org/#narrow/stream/9-issues/topic/Message.20edit.20checkboxes.
Basically, added a feature that supports the selection of message edit
send_notificationcheckboxes by clicking over it's corresponding label as well (The similar case as in organization checkboxes).Screenshot