remote_server: Add management command for deactivation.

[eeshangarg]

Testing plan:

• The mobile_push_service management command was tested manually and then the outcome was verified by manually checking the database via python3 manage.py shell.
• The rest of the changes have accompanying unit tests.

[eeshangarg]

CodeQL was complaining about mobile_push_service.py outputting the SECRETS_FILENAME and was labeling it as "logging potentially secret data". I marked it as a false positive since we are only just logging the path to the file and not any actual secrets.

[eeshangarg]

@timabbott This PR is now ready for review! Thanks! :)

[timabbott]

I merged the first commit as 7a1ed9a.

[timabbott]

I think this should use the rest_path authentication, just like sending a push notification -- the zulip_org_id / zulig_org_key pair is authentication.

[timabbott]

Can you do this error-handling refactoring in preparatory commits? Renaming this tool is a sensitive operation that will need to be merged carefully, since we don't want to make our documentation confusing, so we want only changes necessary to the renaming operation in that commit.

[timabbott]

We should display some sort of error if this doesn't succeed, right?

[timabbott]

(Ideally, just the error response returned by the server).

[timabbott]

Or if _request_push_notification_bouncer_url ensures it can't have failed, we should have an assert rather than an if statement.

[timabbott]

"The mobile push notification service registration for your server has been deactivated".

[eeshangarg]

@timabbott I just addressed your feedback. Thanks!

[timabbott]

I added this change, after reordering commits so that the "Fail API requests if deactivated" commit is before this one.

diff --git a/zerver/tests/test_push_notifications.py b/zerver/tests/test_push_notifications.py
index f4dd9c34cd..07dfc02b6c 100644
--- a/zerver/tests/test_push_notifications.py
+++ b/zerver/tests/test_push_notifications.py
@@ -2514,6 +2514,16 @@ class PushBouncerSignupTest(ZulipTestCase):
         assert remote_realm_audit_log is not None
         self.assertTrue(server.deactivated)
 
+        # Now test that trying to deactivate again reports the right error.
+        result = self.uuid_post(
+            zulip_org_id, "/api/v1/remotes/server/deactivate", request, subdomain=""
+        )
+        self.assert_json_error(
+            result,
+            "The mobile push notification service registration for your server has been deactivated",
+            status_code=401,
+        )
+
     def test_push_signup_invalid_host(self) -> None:
         zulip_org_id = str(uuid.uuid4())
         zulip_org_key = get_random_string(64)

[timabbott]

I merged the series ending with 93329c2 after the small changes noted above and adding a small commit of my own. Thanks for making this reviewable @eeshangarg!

The last couple commits remaining on this PR look reasonable, but we need to think carefully about the name for the script as well as how we want to document the change in name. I'll start a chat.zulip.org conversation.

[zulipbot]

Heads up @eeshangarg, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.