Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve topic search suggestions. #20942

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Improve topic search suggestions. #20942

merged 2 commits into from
Jan 27, 2022

Conversation

showell
Copy link
Contributor

@showell showell commented Jan 27, 2022

No description provided.

We no longer limit our list of candidate topics
to 300.

We continue to limit the topic results to 10, since
we don't want to overwhelm users or crowd out
non-topic-related suggestions.

We try to handle this is an efficient manner.
@timabbott
Copy link
Sponsor Member

Merged, thanks @showell!

I think in theory we could replace the second commit with adding a callback; stream_topic_history_util.get_server_history(stream_id, () => {}); passes an empty callback, and I think if that just called whatever function that will refresh the search box (idunno if bootstrap typeahead has a good way to do this).

@showell
Copy link
Contributor Author

showell commented Jan 27, 2022

Merged, thanks @showell!

I think in theory we could replace the second commit with adding a callback; stream_topic_history_util.get_server_history(stream_id, () => {}); passes an empty callback, and I think if that just called whatever function that will refresh the search box (idunno if bootstrap typeahead has a good way to do this).

I am a bit skeptical of trying this. I think in ~50% of the cases, the server response won't arrive until the user hits the next keystroke, or, even worse, it will arrive just as the user is about to select a choice, and then we will end up pulling the rug out from the user. I have dealt with other apps that overly churn the autocomplete results, and it's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants