czo experiment: Require keyboard to turn on blue box. #20961
Conversation
|
I played around with this in the dev environment, and once turned on, the blue box currently doesn't disappear as often as I was imagining. In particular, it sticks around after:
|
This is roughly based on issue zulip#20934. If you click to enter a new narrow, we always disable the blue box. If you narrow with most keyboard shortcuts, notably the `n` key, then we will not disable the blue box. (There are some exceptions, like the `A` key, that I don't handle, because they unleash some non-trivial codepaths that are outside the scope of a quick experiment to debug.) To enable the blue box, you can hit either up arrow or down arrow once, and then subsequent clicks will start navigating up or down. You can also use other navigation keys like page-up, and they will immediately navigate you, as well as turning on the blue box. If you click on any part of the app that doesn't already have a click handler, that will disable the blue box for you.
|
The build failures here are for node tests, and that shouldn't block a deployment here. These changes were tested off of main, not the czo branch, so you will probably want to pull the other UI-experiment changes off of czo first. I am not sure there are actual conflicts, though. |
|
I played with the updated version -- looks good to me! |
|
Heads up @showell, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636
to
88b200c
Compare
No description provided.