New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
message_edit: Close message edit UI after message is moved. #22681
Conversation
Hello @zulip/server-message-view members, this pull request was labeled with the "area: message-editing" label, so you may want to check it out! |
@punchagan , @amanagr Can you please take a look at this PR. |
eb602f8
to
ba2bcb4
Compare
Can you fix the CI failure? |
ba2bcb4
to
41bade4
Compare
Ahh, sorry for missing on this, Fixed the CI failure! |
Currently, if we navigate to some other topic/stream while the message is being moved, the message edit UI still remains open as we do not get its `row` in `message_lists.current` since the message has not moved yet to the stream/topic we navigated. Hence the correct thing to do would be to delete the message_id from `currently_editing_messages` if it exists there but we cannot find the row. Fixes zulip#21724.
41bade4
to
33977cc
Compare
Looks good to me, tagged to merge once CI passes. Please prioritize the follow-up PR to check who did the edit -- I think it's potentially a more important bug than this one, since the consequence of that bug is potentially losing work. |
@jai2201 Just to check, has this been done? If so, it would be great to link the PR here for the record. |
Currently, if we navigate to some other topic/stream
while the message is being moved, the message edit UI
still remains open as we do not get its
row
inmessage_lists.current
since the message has not moved yetto the stream/topic we navigated.
Hence the correct thing to do would be to delete
the message_id from
currently_editing_messages
if itexists there but we cannot find the row.
Fixes #21724.
Fixes: #21724
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: