Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message_edit: Close message edit UI after message is moved. #22681

Merged
merged 1 commit into from Aug 9, 2022

Conversation

jai2201
Copy link
Collaborator

@jai2201 jai2201 commented Aug 9, 2022

Currently, if we navigate to some other topic/stream
while the message is being moved, the message edit UI
still remains open as we do not get its row in
message_lists.current since the message has not moved yet
to the stream/topic we navigated.

Hence the correct thing to do would be to delete
the message_id from currently_editing_messages if it
exists there but we cannot find the row.

Fixes #21724.

Fixes: #21724

Screenshots and screen captures:

Self-review checklist

  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: S area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) area: message-editing bug priority: high labels Aug 9, 2022
@zulipbot
Copy link
Member

zulipbot commented Aug 9, 2022

Hello @zulip/server-message-view members, this pull request was labeled with the "area: message-editing" label, so you may want to check it out!

@jai2201
Copy link
Collaborator Author

jai2201 commented Aug 9, 2022

@punchagan , @amanagr Can you please take a look at this PR.

@timabbott
Copy link
Sponsor Member

Can you fix the CI failure?

@jai2201
Copy link
Collaborator Author

jai2201 commented Aug 9, 2022

Ahh, sorry for missing on this, Fixed the CI failure!
Thanks!

Currently, if we navigate to some other topic/stream
while the message is being moved, the message edit UI
still remains open as we do not get its `row` in
`message_lists.current` since the message has not moved yet
to the stream/topic we navigated.

Hence the correct thing to do would be to delete
the message_id from `currently_editing_messages` if it
exists there but we cannot find the row.

Fixes zulip#21724.
@timabbott timabbott enabled auto-merge (rebase) August 9, 2022 23:24
@timabbott timabbott merged commit 1986b37 into zulip:main Aug 9, 2022
@timabbott
Copy link
Sponsor Member

Looks good to me, tagged to merge once CI passes.

Please prioritize the follow-up PR to check who did the edit -- I think it's potentially a more important bug than this one, since the consequence of that bug is potentially losing work.

@alya
Copy link
Contributor

alya commented Sep 6, 2022

Looks good to me, tagged to merge once CI passes.

Please prioritize the follow-up PR to check who did the edit -- I think it's potentially a more important bug than this one, since the consequence of that bug is potentially losing work.

@jai2201 Just to check, has this been done? If so, it would be great to link the PR here for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) area: message-editing bug priority: high size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message edit UI still open after message is moved
4 participants