Make switching to and from the preview mode more convenient #22726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching back to writing mode after preview mode, the composebox would be out of focus and so the the cursor would semingly get lost. Now on clearing the preview mode, the composebox is focused and so the cursor is seen blinking at it's original position.
Till now, switching back to writing mode after preview mode, needed the user to first focus on the `Write` (unpreview) button by tabbing to it (if using keyboard) and then select it. To make things easier, especially when using keyboard, now the `Write` button will be automatically focused on entering preview mode, so going back to writing mode only needs one 'Enter` keystroke.
|
Nice, merged, thanks for fixing these @N-Shar-ma! These keyboard interaction details are definitely the sort of thing that can be very meaningful for folks who prefer to use keyboard navigation. |
N-Shar-ma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching back to writing mode after preview mode, the composebox
would be out of focus and so the the cursor would semingly get lost.
Now on clearing the preview mode, the composebox is focused and so the
cursor is seen blinking at it's original position.
Till now, switching back to writing mode after preview mode, needed
the user to first focus on the
Write(unpreview) button by tabbingto it (if using keyboard) and then select it.
To make things easier, especially when using keyboard, now the
Writebutton will be automatically focused on entering preview mode, so
going back to writing mode only needs one 'Enter` keystroke.
Fixes: CZO thread
Screenshots and screen captures:
Entering and exiting preview mode using keyboard:
https://user-images.githubusercontent.com/68962290/184899009-5997e5db-1e79-411d-9d95-e5b525a43e07.mp4
Unpreview button focused immediately after entering preview mode
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: