stream settings: Show stream header in narrow view. #22965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the streams overlay so that the header with the stream name or with 'Create stream' is also visible in a narrow window. Resolves zulip#22963
|
Nice! @ganpa3 would you be up for reviewing this one? |
|
LGTM. |
|
Great! This small change has been approved by @ganpa3 , and looked good to me in manual testing. @timabbott please take a look. :) |
juliaBichler01
changed the title
juliaBichler01
changed the title
alya
added
the
integration review
|
Oops, looks like I forgot to add the "integration review" label earlier! |
timabbott
reviewed
Oct 13, 2022
| #groups_overlay { | ||
| .display-type { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
@m-e-l-u-h-a-n I'm not sure whether the group_overlay block here should be removed as well; can you test that and submit a quick PR if appropriate?
|
Merged, thanks @juliaBichler01! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the streams overlay so that the header with the stream name or with 'Create stream' is also visible in a narrow window.
Resolves #22963