muting: Extract muted_users.js from muting.js. #23024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashaviator
force-pushed
the
user_topics
branch
from
f6ae47a
to
52dbdcd
Compare
This extracts tests for muting users from muting.js (in `frontend_tests/node_tests`) into a new file muted_users.js. Now, all the tests in muting.js are for testing muting of topics.
This renames muting.js (in `frontend_tests/node_tests`) to user_topics.js. This file will now contain all the tests related to the new user_topics data structure.
timabbott
force-pushed
the
user_topics
branch
from
52dbdcd
to
cb20419
Compare
|
This is great, merged after changing the first commit message title to make clear it was renaming a node test file, not the actual runtime code. I guess I should have done that for the second commit too, but didn't notice until after merging. Thanks @akashaviator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts
muted_users.jsinfrontend_tests/node_testsfrommuting.js, and renamesmuting.jsto a more appropriateuser_topics.jswhich will contain tests for features related to the newuser_topicsdata structure in the future.