-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streams: Make default notifications settings customizable per-stream. #23943
Open
Ujjawal3
wants to merge
2
commits into
zulip:main
Choose a base branch
from
Ujjawal3:Issue-23873
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ujjawal3
force-pushed
the
Issue-23873
branch
2 times, most recently
from
January 2, 2023 10:08
af78140
to
011002f
Compare
Ujjawal3
force-pushed
the
Issue-23873
branch
2 times, most recently
from
January 4, 2023 08:35
2e09c83
to
38eebc4
Compare
Ujjawal3
force-pushed
the
Issue-23873
branch
8 times, most recently
from
January 5, 2023 20:07
89fe500
to
e40cc8e
Compare
Ujjawal3
changed the title
Add new feature
settings:Make default notifications settings customizable per-stream
Jan 5, 2023
Ujjawal3
force-pushed
the
Issue-23873
branch
8 times, most recently
from
January 8, 2023 08:06
b8c3071
to
d7f520d
Compare
Ujjawal3
force-pushed
the
Issue-23873
branch
2 times, most recently
from
April 15, 2023 12:18
1a8258c
to
bc98fa4
Compare
Ujjawal3
changed the title
settings:Make default notifications settings customizable per-stream
streams: Make default notifications settings customizable per-stream.
Apr 20, 2023
1 task
Ujjawal3
force-pushed
the
Issue-23873
branch
3 times, most recently
from
May 8, 2023 11:33
75b6327
to
8fc92a7
Compare
Added a new option for administrators in stream creation form which allows to choose the default value of push notifications when a stream in subscribed. If set to true push notificatios will be enabled on subscribing a stream. If set to false push notifications will depend on user-level settings. Fixes zulip#23873.
Heads up @Ujjawal3, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
August 18, 2023 23:51
4ec3636
to
88b200c
Compare
timabbott
added
the
completion candidate
PRs with reviews that may unblock merging
label
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
completion candidate
PRs with reviews that may unblock merging
has conflicts
integration review
Added by maintainers when a PR may be ready for integration.
size: XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new boolean field
push_notifications_enabled
in Steam model. If this field is set to true push notifications will be enabled by default for new subscribers of steam. Default value of this field is false.Fixes: #23873
Screenshots and screen captures:
ScreenShot showing Stream Creation form for owner
Tooltip shown when push notifications are not configured on server.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: