Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts: Convert emoji.js to TypeScript. #24875

Merged
merged 2 commits into from
Apr 5, 2023
Merged

ts: Convert emoji.js to TypeScript. #24875

merged 2 commits into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. emoji: Refactor get_emoji_details_by_name function. 

    This is a prep commit for typescript migration of `emoji.js`. This
commit refactors the code for generating emoji rendering details such
that we avoid writing an ugly code which will involve writing an
incomplete type object when we migrate to TypeScript.
    @Lalit3716
    Lalit3716 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9bc2f7c View commit details
    Browse the repository at this point in the history

  2. ts: Convert emoji.js to TypeScript. 

    Converted `emoji.js` to TypeScript by adding relevant type definitions,
also modified `target` option in our tsconfig to 'ESNext' so that types
for object methods like `hasOwn` which is being used in `emoji.js` are
included.
    @Lalit3716
    Lalit3716 committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    58f23c5 View commit details
    Browse the repository at this point in the history