-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui_redesign: Apply blue links style to message view UI. #25561
Conversation
Hello @zulip/design members, this pull request was labeled with the "UI experiment", "redesign" labels, so you may want to check it out! |
Thank you for doing this. Let's please tune styles like this: Dark theme: Light theme: |
Thank you for the feedback! Will do that tomorrow. |
0fe2682
to
493d6da
Compare
Hello @terpimost! I've updated the PR reflecting your feedback, please have a look. |
I think you're looking at |
yes, sorry, my bad. Hey @alya and @timabbott please take a look at link styles. |
Pushed a commit to resolve conflict. |
@Joelute Could you please update the PR description to make it clear what the three screenshots in each group represent? |
@zulipbot add "mentor review" |
@zulipbot add "buddy review" |
Lets watch it on CZO and people will tell us if they hate it |
With the current Zulip redesign, we would like to tune the colors of the links with a slight underline for better accessibility. These changes to the links only applies to the main message view interface. Fixes: zulip#24877.
4ec3636
to
88b200c
Compare
Heads up @Joelute, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Closing in favor of #29629, which has this already rebased. |
With the current Zulip redesign, we would like to tune the colors of the links with a slight underline for better accessibility. These changes to the links only applies to the main message view interface.
Fixes: #24877.
Screenshots and screen captures:
Light mode:
Message view:
Unread banners:
Compose banner:
Dark mode:
Message view:
Unread banners:
Compose banners:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: