Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui_redesign: Apply blue links style to message view UI. #25561

Closed
wants to merge 1 commit into from

Conversation

Joelute
Copy link
Collaborator

@Joelute Joelute commented May 11, 2023

With the current Zulip redesign, we would like to tune the colors of the links with a slight underline for better accessibility. These changes to the links only applies to the main message view interface.

Fixes: #24877.

Screenshots and screen captures:

Light mode:

Message view:
image
image
image

Unread banners:
image
image
image

Compose banner:
image
image
image

Dark mode:

Message view:
image
image
image

Unread banners:
image
image
image
Compose banners:
image
image
image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: L priority: high redesign Part of the webapp redesign project, including blockers. UI experiment Design direction to be evaluated labels May 11, 2023
@zulipbot
Copy link
Member

Hello @zulip/design members, this pull request was labeled with the "UI experiment", "redesign" labels, so you may want to check it out!

@terpimost
Copy link
Collaborator

Thank you for doing this. Let's please tune styles like this:
text-underline-offset: 3px;

Dark theme:
normal: hsla(200, 100%, 43%, 1) and text-decoration-color: hsla(200, 100%, 43%, 0.3);
hover: hsla(200, 100%, 60%, 1) and text-decoration-color: hsla(200, 100%, 60%, 1)
active: color: hsla(200, 100%, 43%, 1); and text-decoration-color: hsla(200, 100%, 40%, 1);

Light theme:
normal: color: hsl(210 94% 42% / 1) and text-decoration-color: hsla(210, 94%, 42%, 0.2);
hover: color: hsl(212 100% 50% / 1) and text-decoration-color: hsla(210, 100%, 50%, 0.7);,
active: color: hsl(212 100% 30% / 1) and text-decoration-color: hsla(210, 100%, 30%, 1);,

@Joelute
Copy link
Collaborator Author

Joelute commented May 12, 2023

Thank you for the feedback! Will do that tomorrow.

@Joelute Joelute force-pushed the blue-style branch 2 times, most recently from 0fe2682 to 493d6da Compare May 12, 2023 19:48
@Joelute
Copy link
Collaborator Author

Joelute commented May 12, 2023

Hello @terpimost! I've updated the PR reflecting your feedback, please have a look.

@terpimost
Copy link
Collaborator

I think I still see the old style:
image

@Joelute
Copy link
Collaborator Author

Joelute commented May 14, 2023

I think you're looking at main in that screenshot, the stylings looks like the old stylings, not from the PR at all.

@terpimost
Copy link
Collaborator

yes, sorry, my bad. Hey @alya and @timabbott please take a look at link styles.

@Joelute
Copy link
Collaborator Author

Joelute commented May 15, 2023

Pushed a commit to resolve conflict.

@alya
Copy link
Contributor

alya commented May 15, 2023

Thanks! I think it's worth trying on CZO.

From a little bit of playing around with it, I liked how to it looks in banners, but was less sure about messages, specifically when the underline ends up being right next to the blue box.

Screen Shot 2023-05-15 at 2 07 10 PM
Screen Shot 2023-05-15 at 2 02 47 PM

@alya
Copy link
Contributor

alya commented May 15, 2023

@Joelute Could you please update the PR description to make it clear what the three screenshots in each group represent?

@alya alya added the chat.zulip.org review Added by maintainers when a PR requires chat.zulip.org testing to proceed. label May 15, 2023
@timabbott timabbott added the post release Issues to focus attention on after the current major release label May 15, 2023
@Joelute
Copy link
Collaborator Author

Joelute commented Jun 4, 2023

@zulipbot add "mentor review"

@zulipbot zulipbot added the mentor review GSoC mentor review needed. label Jun 4, 2023
@Joelute
Copy link
Collaborator Author

Joelute commented Jun 6, 2023

@zulipbot add "buddy review"

@zulipbot zulipbot added the buddy review GSoC buddy review needed. label Jun 6, 2023
@terpimost
Copy link
Collaborator

when the underline ends up being right next to the blue box
The line isn't strong so there should be no confusion. The underline is stronger on hover, which is for a moment.

Lets watch it on CZO and people will tell us if they hate it

With the current Zulip redesign, we would like to tune the colors of the
links with a slight underline for better accessibility. These changes to
the links only applies to the main message view interface.

Fixes: zulip#24877.
@zulipbot
Copy link
Member

Heads up @Joelute, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@timabbott timabbott added the completion candidate PRs with reviews that may unblock merging label Jan 19, 2024
@alya alya removed post release Issues to focus attention on after the current major release chat.zulip.org review Added by maintainers when a PR requires chat.zulip.org testing to proceed. buddy review GSoC buddy review needed. mentor review GSoC mentor review needed. labels Feb 5, 2024
@timabbott
Copy link
Sponsor Member

Closing in favor of #29629, which has this already rebased.

@timabbott timabbott closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion candidate PRs with reviews that may unblock merging has conflicts priority: high redesign Part of the webapp redesign project, including blockers. size: L UI experiment Design direction to be evaluated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI redesign: blue links style
5 participants