ts: Migrate vdom.js to TypeScript
#26272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
buddy review
PIG208
reviewed
Jul 17, 2023
| @@ -2,7 +2,26 @@ import _ from "lodash"; | |||
|
|
|||
| import * as blueslip from "./blueslip"; | |||
|
|
|||
| export function eq_array(a, b, eq) { | |||
| type Equal<T> = (...args: T[]) => boolean; | |||
There was a problem hiding this comment.
eq for Node takes 1 argument, eq for eq_array takes 2 arguments. Let's type them separately to be more precise.
Added type annotations for variables, function params, and return values. Created custom types that help with clean type annotations. Notes on `attrs` field in custom `Option` type: `attrs` is an `Iterable` where each element is a pair of string, i.e a string array with two elements. `attrs` is tranformed into a `Map` at some point. `Map` constructor takes in `Iterable` object so has no problem unifying with `attrs`. However, at some point `attrs` is transfomed using `.map(...)` which is an array method, and `Iterable` does not support `.map(...)`. So at this point, I cast `attrs` into array before using `.map(...)` by this syntax: `[..attrs].map(...)`
zulipbot
added
integration review
|
Merged, thanks @jychen630 and @PIG208! |
andersk
added
the
area: typescript migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations for variables, function params, and return values. Created custom types that help with clean type annotations.
Notes on
attrsfield in customOptiontype:attrsis anIterablewhere each element is a pair of string, i.e a string array with two elements.attrsis tranformed into aMapat some point.Mapconstructor takes inIterableobject so has no problem unifying withattrs. However, at some pointattrsis transfomed using.map(...)which is an array method, andIterabledoes not support.map(...). So at this point, I castattrsinto array before using.map(...)by this syntax:[..attrs].map(...)Much inference is inspired by
vdom.test.js.Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: