Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: Remove duplicate heading IDs on server side #26541

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

andersk
Copy link
Member

@andersk andersk commented Aug 21, 2023

No description provided.

There was no particular reason for this to be the single page that
documented multiple API endpoints, and splitting it fixes a duplicate
ID parameter-stream_id.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
* [Mark messages as read in bulk](/api/mark-all-as-read)
* [Mark all messages as read](/api/mark-all-as-read)
* [Mark messages in a stream as read](/api/mark-stream-as-read)
* [Mark messages in a topic as read](/api/mark-topic-as-read)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have an open issue to remove all three of these endpoints in favor of the new endpoint created for "mark unread".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s #23598. (But that’s likely to take a while and shouldn’t block this fix.)

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep agreed.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
@zulipbot zulipbot added size: XL and removed size: S labels Aug 21, 2023
@timabbott timabbott merged commit 328cdde into zulip:main Aug 22, 2023
16 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks for cleaning this up @andersk!

@andersk andersk deleted the duplicate-id branch August 22, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants