Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming display settings -> preferences #27822

Closed
wants to merge 0 commits into from
Closed

renaming display settings -> preferences #27822

wants to merge 0 commits into from

Conversation

Aditya8840
Copy link
Collaborator

@Aditya8840 Aditya8840 commented Nov 21, 2023

Finished renaming display settings -> preferences

Fixes #26874

web/e2e-tests/settings.test.ts
web/src/admin.js
web/src/server_events_dispatch.js
web/src/settings.js
web/src/settings_config.ts
web/templates/settings/display_settings.hbs
web/templates/settings/organization_user_settings_defaults.hbs
web/templates/settings/user_display_settings.hbs
web/templates/settings_tab.hbs
web/tests/i18n.test.js
zerver/actions/user_settings.py
zerver/lib/event_schema.py
zerver/lib/events.py
zerver/models.py
zerver/tests/test_event_system.py
zerver/tests/test_events.py
zerver/tornado/event_queue.py

@zulipbot
Copy link
Member

Hello @Aditya8840, it seems like you have referenced #26874 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #26874..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish renaming Display settings -> Preferences
2 participants