Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26480 : Prevent color leak due to dragging of table row in settings and custom profile fields #28238

Closed
wants to merge 0 commits into from

Conversation

Kota-Karthik
Copy link
Collaborator

Fixes: #26480

Screenshots and screen captures:
These are screenshots and screen captures after i have made the changes:-
Screenshot from 2023-12-12 19-36-56
Screenshot from 2023-12-12 19-37-08

After_Changes_Final.mov
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.
I had adjusted the background color value which was causing the problem @timabbott Kindly review the PR and please tell me weather any changes needed!! Thank You : )

@Kota-Karthik Kota-Karthik changed the title Prevent color leak due to dragging of table row in settings and custom profile fields Fixes #26480 : Prevent color leak due to dragging of table row in settings and custom profile fields Dec 14, 2023
@Kota-Karthik
Copy link
Collaborator Author

@timabbott
I had made the PR for #26480
kindly review it and please tell me whether any changes needed!!

Comment on lines 798 to 803
border-color: hsl(0deg 0% 0% / 20%);
background-color: hsl(0deg 0% 0% / 20%);
background-color: hsl(212deg 28% 15%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes color for a a lot of elements, can we just keep it scoped to the tables we want to fix the background for. Also, looks like there is white border in you video when drag the table row, would be great to remove that too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ,I will do the required changes wherever needed and will inform you , once its done!!
Thank You : )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanagr
color changes scoped to tables we want to fix the background color for
But i was not able to solve the problem of that white border while dragging the table row
I was not able to find the CSS for which this problem keeps occuring
But as per the issue #26480 I have solved it
It would be great , if you review this once again
Thank You : )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I cannot approve this PR until my comment is addressed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanagr
I would fix that white border issue
but could you tell me whether the other changes I made are correct and have no problem ?
Thank You: )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes color for a lot of elements, can we just keep it scoped to the tables we want to fix the background for.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanagr
color changes scoped to tables we want to fix the background color for
as per the issue #26480 I have solved it
It would be great , if you review this once again
Thank You : )

@zulipbot zulipbot added size: S and removed size: XS labels Dec 18, 2023
@Kota-Karthik
Copy link
Collaborator Author

@amanagr
It would be great if you can review this PR
and let me know if any changes needed
Thank You: )

@zulipbot
Copy link
Member

Hello @Kota-Karthik, it seems like you have referenced #26480 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #26480..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragging rows in settings with dark theme enabled looks weird
3 participants