-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #26480 : Prevent color leak due to dragging of table row in settings and custom profile fields #28238
Conversation
@timabbott |
web/styles/dark_theme.css
Outdated
border-color: hsl(0deg 0% 0% / 20%); | ||
background-color: hsl(0deg 0% 0% / 20%); | ||
background-color: hsl(212deg 28% 15%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes color for a a lot of elements, can we just keep it scoped to the tables we want to fix the background for. Also, looks like there is white border in you video when drag the table row, would be great to remove that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ,I will do the required changes wherever needed and will inform you , once its done!!
Thank You : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amanagr
color changes scoped to tables we want to fix the background color for
But i was not able to solve the problem of that white border while dragging the table row
I was not able to find the CSS for which this problem keeps occuring
But as per the issue #26480 I have solved it
It would be great , if you review this once again
Thank You : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I cannot approve this PR until my comment is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amanagr
I would fix that white border issue
but could you tell me whether the other changes I made are correct and have no problem ?
Thank You: )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes color for a lot of elements, can we just keep it scoped to the tables we want to fix the background for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amanagr |
447a2c8
to
aa2f7fe
Compare
Hello @Kota-Karthik, it seems like you have referenced #26480 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
Fixes: #26480
Screenshots and screen captures:
These are screenshots and screen captures after i have made the changes:-
After_Changes_Final.mov
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: