Web: Use Intl.ListFormat rather than .join(", ")

[CIC4DA]

This PR brings internationalization by replacing the inconsistent .join(", ") with Intl.ListFormat for accurate and localized list formatting, using a common utility function.

Screenshot of Visual Changes:

Edit : Removed Internationalization from left side bar.

• Files which were to be internationalized are using Intl.ListFormat.
• Uses { style: "long", type: "conjunction" } could be changed according to use.
• Add a fallback system for MacOs.
• Refactor tests to test with the new changes.

Fixes: #26936 Use Intl.ListFormat rather than .join(", ")

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

• Explains differences from previous plans (e.g., issue description).
• Highlights technical choices and bugs encountered.
• Calls out remaining decisions and concerns.
• Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

• Each commit is a coherent idea.
• Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[zulipbot]

Hello @CIC4DA, it seems like you have referenced #26936 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #26936..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

[timabbott]

The web/src/message_notifications.js code path appears to use this field for non-display purposes to construct unique keys; I think that might now be incorrect

The web/src/recent_view_ui.js code also seems to sort by message.display_reply_to; does that seem correct to you? Might require some auditing.

[CIC4DA]

In web/src/message_notifications.js, we can convert back the internationalized list to an array and then to a list using .join(", "), and then set the key.

Something like this :

const reconstructed_list = message.display_reply_to
                          .replace('and', '') 
                          .split(',')
                          .map(item => item.trim())
                          .join(", ");

key = reconstructedList;

I'm not sure about web/src/recent_view_ui.js, as it uses message.display_reply_to for sorting and message.display_reply_to are already sorted name, with an extra and in it. Will it effect the sorting of multiple strings?
What is your view about it?

[timabbott]

@CIC4DA thanks for working on this; it looks pretty promising. I think what we'll need to merge this are:

• Addressing the above feedback.
• Making sure that test-js-with-node passes after each commit -- it looks like some of the test changes are in the wrong commit as noted in comments above, and this would prevent me from merging only the parts of this PR that I can approve to simplify further review.
• Posting screenshots of the visual changes for review, at least for the majority of commits where only one place changes, so we can discuss if in any cases we want different ListFormat settings in any of them.

I expect to be able to merge most of the commits after that; the display_reply_to one might be worth just dropping from this and doing in a separate follow-up PR, just because it seems like it might touch a lot of UI/logic.

[CIC4DA]

@timabbott, I have done the following:

• Addressed the feedback.
• Each test change is included in the commit of file which caused the change.
• Added a screenshot of the visual changes.
• Removed message_store.display_replay_to commit from this PR

[timabbott]

I extracted several commits to #28611 to merge those; posting comments on the rest.

[CIC4DA]

@timabbott I have made some required changes, and requires suggestion from you on above reviews, kindly take a look. Thanks.

[CIC4DA]

The function get_cleaned_pm_recipients of typehead_helper.ts, was only used in .on(blur) function. But I didn't removed it as it can be used further in future. And to cover it in test, Added a test for get_cleaned_pm_recipients in typehead_helper.test.js

[zulipbot]

Heads up @CIC4DA, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.