Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: Document how to configure warnings about mobile notifications. #28717

Conversation

drrosa
Copy link
Collaborator

@drrosa drrosa commented Jan 26, 2024

Documents the new setting to control warning banners about mobile push notifications.

Fixes #28707.

Screenshots and screen captures:

Self-review checklist

Communicate decisions, questions, and potential concerns.

  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: S area: documentation (user) area: mobile Mobile push notifications; features motivated by mobile; issues requiring changes in mobile code. priority: high labels Jan 26, 2024
@zulipbot
Copy link
Member

Hello @zulip/server-user-docs members, this pull request was labeled with the "area: documentation (user)" label, so you may want to check it out!

@drrosa
Copy link
Collaborator Author

drrosa commented Jan 26, 2024

@alya This PR is ready for review.

@alya
Copy link
Contributor

alya commented Jan 26, 2024

Works for me! Thanks for the quick turnaround.

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Jan 26, 2024
@alya
Copy link
Contributor

alya commented Jan 26, 2024

@chrisbobbe @gnprice FYI

@chrisbobbe
Copy link
Contributor

With zulip/zulip-mobile#5814 having just been merged, the setting label is instead:

Silence warnings about disabled mobile notifications

, not

Silence warnings about disabled mobile push notifications

, since we wanted to make it a bit shorter.

Documents the new setting to control warning banners about
mobile push notifications.

Fixes zulip#28707.
@timabbott timabbott force-pushed the help-document-how-to-turn-off-warnings-about-mobile-notifications branch from b5dbc4d to 005de8f Compare January 28, 2024 22:30
@timabbott
Copy link
Sponsor Member

Made that wording tweak and marked to merge once CI passes.

@timabbott timabbott enabled auto-merge (rebase) January 28, 2024 22:31
@timabbott timabbott merged commit fd48971 into zulip:main Jan 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation (user) area: mobile Mobile push notifications; features motivated by mobile; issues requiring changes in mobile code. integration review Added by maintainers when a PR may be ready for integration. priority: high size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to turn off warnings about mobile notifications
5 participants