Fix: order of group direct message recipients.

[richardshaju]

Fix: order of group direct message recipients
Fixes: #27375

Screenshots and screen captures:
before :

after:

Self-review checklist

• Self-reviewed the changes for clarity and maintainability
  (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

Completed manual review and testing of the following:

• Visual appearance of the changes.
• Responsiveness and internationalization.
• Strings and tooltips.
• End-to-end functionality of buttons, interactions and flows.
• Corner cases, error conditions, and easily imagined bugs.

[richardshaju]

Changes made as per the review.

[timabbott]

Can you explain how this completes the issue? It talks about several locations and the issue of case-insensitive ordering, and I'd like to see a complete audit confirming this results in the intended logic in all places listed.

[richardshaju]

I apologize for any inconvenience caused. I will take the necessary steps to make the required changes.

[richardshaju]

Before:

After:

[timabbott]

@richardshaju can you fix the test failures?

I appreciate the screenshots, but I'd also appreciate a paragraph or so write-up explaining the analysis for how you determined this is a complete and correct solution.

[timabbott]

Also it'd be helpful if you discuss how you've addressed the feedback on #27557, a previous PR for this feature.

[richardshaju]

• As mentioned in the issue, the DMs list in the left sidebar can be sorted by using the util.make_strcmp() in the function get_recipients() in people.ts.

• The order of the placeholder shown below is fixed by the same approach as the above. This time at get_pm_full_names() in message_store.ts.

• This order is fixed again through the same approach at compare_by_name in message_list_view.js.

---

All the order of names given below including the pills are fixed using the new function sort_emails() in people.ts. This new function sorts the emails based on their full names. This new function is used in user_ids_string_to_emails_string() and pm_reply_to() both are from people.ts.

• The given below are fixed by the user_ids_string_to_emails_string() by using the sort_emails()

• The given below problem is fixed by the pm_reply_to() by using the sort_emails()

aaron.Cordelia.Lear.s.daughter.Zoe.-.Zulip.Dev.-.Zulip.-.Google.Chrome.2024-02-15.10-44-16.mp4

[richardshaju]

I appreciate @Jenil-Dobariya for PR #27557. It helped me a lot, especially in writing the tests. I used the same approach with some optimization mentioned in the code review. I think he is nearly finished with the PR work, but unfortunately, he hasn't been responding.

[richardshaju]

@timabbott Please review this.

[pratik-pc]

Hey @richardshaju, I haven't really gone through the code but have found some inconsistencies. It seems it doesn't sort correctly when narrow triggered from message header.

Screencast.from.07-03-24.12.42.26.AM.IST.webm

[richardshaju]

@pratik-pc Thank you for figuring this out.

[richardshaju]

@pratik-pc Is this the correct approach?

All.messages.-.Zulip.Dev.-.Zulip.-.Google.Chrome.2024-03-11.15-22-14.mp4

[pratik-pc]

@richardshaju Some areas are still left

Screencast.from.12-03-24.12.33.10.AM.IST.webm

[richardshaju]

@pratik-pc But in my system it's working properly.

aaron.Desdemona.King.Hamlet.Zoe.-.Zulip.Dev.-.Zulip.-.Google.Chrome.2024-03-13.23-44-05.mp4

[pratik-pc]

Hey @richardshaju, steps to repro are:

• Save to draft with unsorted recipient list
• Then narrow from drafts

Also

• Narrow to group convo from compose box with unsorted recipient list

[richardshaju]

@pratik-pc but now I can't save the draft with the unsorted recipient list.

[pratik-pc]

@richardshaju Here's how it is for me

Screencast.from.15-03-24.11.43.29.PM.IST.webm

[zulipbot]

Heads up @richardshaju, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.