Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "copy" icon | Issue #28700 #28740

Closed
wants to merge 1 commit into from
Closed

Change "copy" icon | Issue #28700 #28740

wants to merge 1 commit into from

Conversation

jayantpranjal0
Copy link
Collaborator

@jayantpranjal0 jayantpranjal0 commented Jan 29, 2024 •
edited

Changes the files copy_to_clipboard_svg.hbs to have the new icon from https://feathericons.com/?query=copy as required by the issue

Fixes: #28700

Screenshots and screen captures:
Before:
image
After
image

image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@jayantpranjal0
Copy link
Collaborator Author

@alya Please review the PR.

@alya
Copy link
Contributor

alya commented Jan 31, 2024

Please include screenshots of everywhere in the app that we have a "copy" icon, not just code blocks.

@jayantpranjal0
Copy link
Collaborator Author

@alya I have added the screenshots of everywhere where we have a "copy" icon. Please review the PR.

@alya
Copy link
Contributor

alya commented Feb 6, 2024 •
edited

As you can see, there are major problems with the appearance of the icon, which it would have been helpful to point out.

It's my bad for not linking the Figma frame that has the icon. I've added a link to the issue. Can you try exporting it from there and seeing if that fixes the problem?

@jayantpranjal0 jayantpranjal0 force-pushed the copy_button_ui branch 2 times, most recently from 9e06bca to 3dabc6d Compare February 6, 2024 22:07
@jayantpranjal0
Copy link
Collaborator Author

As you can see, there are major problems with the appearance of the icon, which it would have been helpful to point out.

It's my bad for not linking the Figma frame that has the icon. I've added a link to the issue. Can you try exporting it from there and seeing if that fixes the problem?

@alya I have changed changed the copy icon design according to the figma design link attached. Please review the PR.

@alya
Copy link
Contributor

alya commented Feb 7, 2024 •
edited

Thanks! Your PR also needs to pass test in order to be ready for review.

@alya
Copy link
Contributor

alya commented Feb 7, 2024 •
edited

We should also update the other "copy" icon we use as part of this issue:

Screenshot 2024-02-06 at 6 07 53 PM

This one also occurs in the user card, and perhaps elsewhere.

@jayantpranjal0
icons: Changed "copy" button.
535d33d 
Fixes: zulip#28700.

change copy icon to figma copy icon

change copy icon to figma copy icon

retrigger checks
@timabbott
Copy link
Sponsor Member

Closing in favor of #29455 for this issue.

@timabbott timabbott closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "copy" icon
4 participants
@jayantpranjal0 @alya @timabbott @zulipbot