Upgrade configuration for Ruff v0.2.0 #28795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @charliermarsh! |
|
v0.2.0 is now live, so happy to update this PR to include the upgrade if you'd like. |
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Signed-off-by: Anders Kaseorg <anders@zulip.com>
|
Thanks! Edited to fix SIM113 instead of disabling it, clarify the RUF019 fix to default booleans to |
andersk
added
the
integration review
Signed-off-by: Anders Kaseorg <anders@zulip.com>
andersk
approved these changes
Feb 2, 2024
|
Merged, thanks @charliermarsh and @andersk! |
|
This was backported in #29234. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades Zulip's Ruff configuration in preparation for Ruff's v0.2.0 release. (The changes are compatible with Ruff v0.1.14, which Zulip uses today.)
Specifically, we're now warning when linter-only options are specified under
[tool.ruff]instead of[tool.ruff.lint]. We've also stabilized some changes toRUF019(and other rules) that led to some new violations, so I just went ahead and applied the fixers.ruff checknow passes without error on Zulip with Ruff v0.2.0.