-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #26874. Finished renaming display_settings to preferences. I had to change the name of some files to preferences in order to avoid conflicts. #29161
Conversation
All the checks have passed. |
@Shgit29, Zulip follows its own commit guidelines. You can read about the commit disciplines and clean up your commit message history. |
I will make sure to follow them the next time. This was my first time submitting a PR to zulip. Is it a must to fix it right now? |
Yes, you can |
the commit message should be |
Hey, so I have changed the commit history now. Thank you so much for pointing it out, and providing me with a solution. |
Thanks, could you please clear the commit description also??. |
Done. |
With the changes made, this PR is ready for review. |
Thanks for the fix! Could you please update your commit message to match the commit style guidelines? |
878f078
to
22bd804
Compare
Done. |
Heads up @Shgit29, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
You have just done a search-and-replace here. I'm closing this PR, because you're making changes to the logic and haven't carefully studied the impact of these changes. Once you understand the impact of your work, you're welcome to open another PR. |
Renamed Display settings to Preferences
Fixes: #26874
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: