-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: Show a first-time banner for jump to sent message conversation. #29590
Conversation
Hello @zulip/design, @zulip/server-onboarding members, this pull request was labeled with the "area: onboarding", "UI experiment" labels, so you may want to check it out! |
2343762
to
5efc8f7
Compare
5efc8f7
to
f38dfd1
Compare
Hm, when I try this from Inbox, it looks like another banner flashes by first. I'm having a hard time capturing it in a screen recording (it's super quick), but maybe you can check in the code whether or not I'm imagining it? |
f38dfd1
to
d6db01e
Compare
d6db01e
to
240b594
Compare
@alya Attaching a video for quick reference of the issue and screenshots to show final behavior: banner-follow.webmThese |
I left a comment in #design. |
Works for me otherwise! When there are two banners, they don't appear simultaneously, but I think that's OK. |
240b594
to
c7dee29
Compare
Updates in the recent push:
For @timabbott : The order in which PRs should be integrated ideally: |
7e83392
to
79673a0
Compare
79673a0
to
5a0f873
Compare
5a0f873
to
9a5aab5
Compare
We immediately navigate the user to the conversation they just sent a message to if they are not already in the appropriate conversation view. This commit adds a first-time banner to explain the same. Fixes zulip#29575.
9a5aab5
to
22f3aeb
Compare
Merged, thanks @prakhar1144! |
The first commit is from #29211 pulled here for testing the flow.
Show a one-time banner when jump to sent message conversation takes place for the first time.
Fixes: #29575
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: