emojisets: Improve error handling when we fail to fetch an emojiset. #29761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we retry 3 times with 10s delays before giving up if on loading the emoji. Hopefully user will just refresh the page by that time if the emojis still can't be displayed.
amanagr
added
the
integration review
|
I'm not sure we needed to add this, but it is probably a good idea and seems clean enough. Merged, thanks @amanagr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we retry 3 times with 10s delays before giving up if on loading the emoji. Hopefully user will just refresh the page by that time if the emojis still can't be displayed.