New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: Redesign limit indicator to show remaining characters count. #29830
Conversation
Hello @zulip/design members, this pull request was labeled with the "redesign" label, so you may want to check it out! |
This lgtm implementation-wise other than the detail there; the one thing that maybe could be optimized further whether there's some tweak to positioning that would make it more obvious what this is. I think it's probably fine but @terpimost @alya FYI in case you want to suggest any changes before we merge this. |
Looks good to me in manual testing! |
By the way, this reminded me of #25271. Not a high priority, but I dunno if it's easy to do while this code is fresh in mind. We don't have an equivalent placement, but maybe to the right of the "Cancel" button would work? We can leave it be if it's not super easy to do, though. |
Please add the integration review label once you've fixed up these nits; I don't think we need to test-deploy this one. |
00443a1
to
6a3f22e
Compare
@zulipbot add "integration review" |
6a3f22e
to
e35af8d
Compare
Additionally, the text colors have been updated for both light and dark themes, it starts showing when 900 or less characters are left, as 999 was too soon, and has a tooltip to show the maximum characters limit. Fixes: zulip#28706.
Since the banner only repeated what the disabled Send button's and the limit indicator's tooltips already said, it was redundant and has been removed.
e35af8d
to
e328e19
Compare
I'm not sure why 900 would be the better number to use than 999, but going to go ahead and merge the design change and I'll post a query about that detail in #design, since it's a tiny nit to change. |
compose: Remove the
message_too_long
banner.Since the banner only repeated what the disabled Send button's and the limit indicator's tooltips already said, it was redundant and has been removed.
compose: Redesign limit indicator to show remaining characters count.
Additionally, the text colors have been updated for both light and dark themes, it starts showing when 900 or less characters are left, as 999 was too soon, and has a tooltip to show the maximum characters limit.
Fixes: #28706.
Screenshots and screen captures:
Light theme:
Close to limit:
Over limit:
Dark theme:
Close to limit:
Over limit:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: