corporate: Migrate discounted customer with a required plan tier. #29890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will migrate existing customers who don't have a required plan tier but have a discount applied.
amanagr
commented
Apr 30, 2024
Comment on lines
+55
to
+65
| if not plan.exists(): | ||
| # Check that realm has no paid plan. | ||
| assert not ( | ||
| Realm.objects.filter(id=customer.realm_id) | ||
| .filter(plan_type__in=REALM_PAID_PLANS) | ||
| .exists() | ||
| ), f"Customer {customer.id} has no paid plan but realm has paid plan. Manually migrate the customer." | ||
| print(f"Customer {customer.id} has discount but no paid plan. Resetting discount.") | ||
| customer.default_discount = None | ||
| customer.save(update_fields=["default_discount"]) | ||
| continue |
There was a problem hiding this comment.
Ideally we should also reset minimum licenses for the customer which is set after discount is applied but I think it is not we want for some customers due to legacy reasons.
This was referenced May 6, 2024
|
Closing this since the migration was manually done by Tim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will migrate existing customers who don't have a required plan tier but have a discount applied.
@timabbott might better to just run the assertion before deploying the script but I think this should be everything we should be checking here.