hashchange: Fix infinite home view <-> narrow loop on escape keypress. #30108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproducer: * Start with empty hash and combined feed as home view. * Go to any narrow. * Keep pressing escape key. You will keep switching between narrow view and home view while you should just stop at home view. This was due to `set_hash_to_home_view` not considering empty hash as a valid home view hash.
|
Merged, thanks @amanagr! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer:
You will keep switching between narrow view and home view while you should just stop at home view. This was due to
set_hash_to_home_viewnot considering empty hash as a valid home view hash.Introduced in f07ed8b
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/Esc.20key.20loop.20with.20combined.20feed