server_events: Fix infinite loading indicator on page load. #30113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding the loading indicator was based on us adding some messages into the view which was no always the case.
|
Looks great, merged, thanks @amanagr! I think it's correct to have this indicator; I'm not certain that all places you can load would otherwise have one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding the loading indicator was based on us adding some messages into the view which was no always the case.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/message.20loading.20spinner.20keeps.20spinning
Reproducer: populate database with no messages
Do we even need this indicator?