Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30075 #30175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixes #30075 #30175

wants to merge 5 commits into from

Conversation

Wislamp
Copy link
Collaborator

@Wislamp Wislamp commented May 23, 2024

This PR corrects the tooltip message and converts the tooltip implementation to use Tippy.js for improved performance and customization.

Fixes:
Fixes #30075 (Correct tooltip message and convert to Tippy.js)

Screenshots and screen captures:
Screenshot (377)

Screenshot (33)

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @Wislamp, it seems like you have referenced #30075 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #30075..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@Wislamp Wislamp changed the title Correct Tooltip Message and Convert Tooltip to Use Tippy.js (issue #30075) Fixes #30075 May 23, 2024
@alya
Copy link
Contributor

alya commented Jun 5, 2024

Thanks for the fix! Please clean up your commit history and post again to request a review. See here for guidelines.

@Wislamp
Copy link
Collaborator Author

Wislamp commented Jun 5, 2024 via email

@zulipbot
Copy link
Member

Heads up @Wislamp, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert channel warning tooltip to Tippy
4 participants