-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #30075 #30175
base: main
Are you sure you want to change the base?
Fixes #30075 #30175
Conversation
Hello @Wislamp, it seems like you have referenced #30075 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
Thanks for the fix! Please clean up your commit history and post again to request a review. See here for guidelines. |
Please okay thank you for the update
…On Wed, 5 Jun 2024, 19:31 Alya Abbott, ***@***.***> wrote:
Thanks for the fix! Please clean up your commit history and post again to
request a review. See here
<https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html>
for guidelines.
—
Reply to this email directly, view it on GitHub
<#30175 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBBXIKKEAZQO5V7NQHBDCNTZF5RQXAVCNFSM6AAAAABIFFUL2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQHAYDOMRYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Heads up @Wislamp, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
This PR corrects the tooltip message and converts the tooltip implementation to use Tippy.js for improved performance and customization.
Fixes:
Fixes #30075 (Correct tooltip message and convert to Tippy.js)
Screenshots and screen captures:
![Screenshot (377)](https://private-user-images.githubusercontent.com/138638377/333101207-ad9cdba2-6eec-480e-ac78-8bd9d135eadb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4OTUyMTMsIm5iZiI6MTcxOTg5NDkxMywicGF0aCI6Ii8xMzg2MzgzNzcvMzMzMTAxMjA3LWFkOWNkYmEyLTZlZWMtNDgwZS1hYzc4LThiZDlkMTM1ZWFkYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwMlQwNDM1MTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYWJkYTgyOGM5MDk4ZDU5YjMxNTEyNDRhNTBkMmFlMmU5ZmQ2ZDljZDA1NDRiZTU3YjVlODkzNWJlYjNhN2QyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.6J6C0Ju0vZ_tZlQdqJ7MzEFpE1-fq3hztxiZiOg3zZ4)
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: