narrow_state: Remove narrowed_to_topic function. #30186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: web/src/compose_closed_ui.ts
Did you find this useful? React with a 👍 or 👎 |
This was only being used in one place in compose_closed_ui to create the label for the closed composebox. But it only checked if the `channel` and `topic` filters existed, while `stream_sub` can return `undefined` for a few other reasons. To ensure that we're catching the undefined sub while also avoiding duplicate work, it makes sense to just call `stream_sub()` directly. Fixes this bug: https://zulip.sentry.io/issues/5367251929/events/40073ecf007a4a9798e728061a576377/?project=450455688282112
evykassirer
force-pushed
the
compose-closed-ui-bug-followup
branch
from
82db939
to
671c2e1
Compare
|
Looks good, merged, thanks @evykassirer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only being used in one place in compose_closed_ui to create the label for the closed composebox. But it only checked if the
channelandtopicfilters existed, whilestream_subcan returnundefinedfor a few other reasons, so it makes sense to just callstream_sub()directly.Fixes this bug:
https://zulip.sentry.io/issues/5367251929/events/40073ecf007a4a9798e728061a576377/?project=450455688282112