compose: Show focus ring on buttons only when using keyboard navigation. #30494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlstolley
reviewed
Jun 19, 2024
N-Shar-ma
force-pushed
the
focus-ring-compose
branch
2 times, most recently
from
198fe91
to
c81e403
Compare
|
This version seems so still show focus rings when clicking compose box buttons with the mouse, for me using Chrome on Linux. |
The css variable `--color-outline-focus`, which affects focus rings throughout the app, now has a different value defined for the dark theme but this should have no visible effect, and help clean up the code. This is a prep commit for the next, which shows focus rings only on `focus-visible` and not on `focus` for composer buttons.
For the compose control buttons, the compose close button, and the send later vdots button, we show the focus ring only on `focus-visible` and not on `focus`. Fixes part of: zulip#27117.
N-Shar-ma
force-pushed
the
focus-ring-compose
branch
from
c81e403
to
6987b81
Compare
|
@timabbott Sorry about that, the default dark theme styling was overriding the new styles, which had been tweaked to make the CSS slightly simpler (and so inadvertently buggy). Have reverted to the 1st draft which has been thoroughly tested, details here |
|
That version seems to work, merged, thanks @N-Shar-ma! We may still be able to find a better refinement, but I think this is a good checkpoint at which to check off the feature. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the compose control buttons, the compose close button, and the send later vdots button, we show the focus ring only on
focus-visibleand not onfocus.Fixes part of: #27117.
css: Redefine
--color-outline-focusfor dark theme.The css variable
--color-outline-focus, which affects focus rings throughout the app, now has a different value defined for the dark theme but this should have no visible effect, and help clean up the code.This is a prep commit for the next, which shows focus rings only on
focus-visibleand not onfocusfor composer buttons.Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: