list_widget: Fix more elements not rendered on scrolling to bottom. #30499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug can be reproduced by scrolling anywhere where list widget is used except recent view. `$scroll_container` was used before 371cd0d to listen to scroll events which was incorrectly replaced by `opts.$simplebar_container` in the above commit. To fix this, we use the same function `scroll_util.get_scroll_element` to get the correct scroll element.
|
Merged, thanks @amanagr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug can be reproduced by scrolling anywhere where list widget is used except recent view.
$scroll_containerwas used before371cd0d
to listen to scroll events which was incorrectly replaced by
opts.$simplebar_containerin the above commit. To fix this, we use the same functionscroll_util.get_scroll_elementto get the correct scroll element.discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/Scrolling.20user.20list