analytics: Send merge_base and more RemoteRealm info to the bouncer. #30513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszmandera
commented
Jun 20, 2024
zerver/lib/remote_server.py
Outdated
| org_type: int = 0 | ||
| icon_url: str = "" |
There was a problem hiding this comment.
not sure whether we want to send icon_url here or if we meant the actual image data - so went with the basic option first.
|
Hmm the |
|
Maybe worth just doing |
mateuszmandera
force-pushed
the
analytics-more-fields
branch
from
9548792
to
ee47872
Compare
mateuszmandera
force-pushed
the
analytics-more-fields
branch
from
ee47872
to
5ae04fa
Compare
The test asserts entries about the zephyr realm anyway. The reason the filter hasn't been limiting the query to zephyr is that we might simultaneously want to ensure no other realms received changes - but that doesn't seem quite right, given that the test doesn't dilligently set up the initial conditions for all realms to have control over what exactly happens with them. That makes this logic pretty fragile since if some new (potentially unrelated) changes to Realm/RemoteRealm initial state make it so some updates to other realms occur during the early analytics upload calls in the test, the remote_audit_logs asserts here will break in a very annoying to debug way. If we want this query to be general, without limiting to the zephyr realm, we could alter the test a bit to set up initial conditions precisely.
|
Changed this to just add merge_base |
|
Looks great, merged, thanks @mateuszmandera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sending a bit more information to the bouncer. At the realm level:
At the server level: