Fix email -> user_id hard codings. #3622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @showell, it looks like you've already signed the Dropbox CLA. Thanks! |
We now convert our pm-with search operand to a list of user ids for matching against messages, rather than using emails. On the message side we look at user ids from display_recipient.
We now use user_ids from the message to generate the reply_to more dynamically.
This will be used for live updating.
When we get notified of an email change and the compose box is open for PMs, we should update the email in the compose box. This helper will be useful when we start handling such events.
|
Some parts of this probably deserves some more node tests eventually, but this looks good. Merged, after fixing a whitespace typo :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.