Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] popovers: rendering the emoji picker only once. #4301

Closed
wants to merge 3 commits into from
Closed

[wip] popovers: rendering the emoji picker only once. #4301

wants to merge 3 commits into from

Commits on Apr 15, 2017

  1. compose: Render the emoji picker only once. 

    * Whenever the emoji picker is opened a call is made to render
  the emoji's. This rendering happend everytime the emoji picker
  was opened. Thus, resulting in duplicates of emoji's getting
  appended in the emoji picker over multiple open and close.

* This commit, is a fix to render the emoji's only once when the
  emoji picker is opened for the first time. Further calls just
  toggles the emoji picker showing the already rendered emoji's.
  This enhances the performance of Emoji picker considerably
  because there is no overhead of making a request to get the emoji's
  from the server, each time the emoji picker is opened.

* Other changes -- on closing the emoji picker, the compose box
  remains in focus.

Fixes: #4300.
See Also: #3952.
    @tejaskasetty
    tejaskasetty committed Apr 15, 2017
    Configuration menu
    Copy the full SHA
    5ae69a7 View commit details
    Browse the repository at this point in the history

  2. compose: Re-render emoji picker when realm_emoji is added/deleted. 

    * reset the emoji popover in case of an event
regarding update of realm_emoji.
* test-node-with-js: Add dependency - popovers module;
In dispath.js to support popovers object.
    @tejaskasetty
    tejaskasetty committed Apr 15, 2017
    Configuration menu
    Copy the full SHA
    302b4a3 View commit details
    Browse the repository at this point in the history

  3. update_emojis: Handle the case involving deletion of realm emoji.

    @tejaskasetty
    tejaskasetty committed Apr 15, 2017
    Configuration menu
    Copy the full SHA
    fc2fcd4 View commit details
    Browse the repository at this point in the history