Support "file:///" as hyperlink

zerver/lib/bugdown/__init__.py

@@ -651,7 +651,7 @@ def sanitize_url(url):
     if not scheme:
         return sanitize_url('http://' + url)
 
-    locless_schemes = ['mailto', 'news']
+    locless_schemes = ['mailto', 'news', 'file']
     if netloc == '' and scheme not in locless_schemes:
         # This fails regardless of anything else.
         # Return immediately to save additional proccessing
@@ -661,7 +661,7 @@ def sanitize_url(url):
     # appears to have a netloc.  Additionally there are plenty of other
     # schemes that do weird things like launch external programs.  To be
     # on the safe side, we whitelist the scheme.
-    if scheme not in ('http', 'https', 'ftp', 'mailto'):
+    if scheme not in ('http', 'https', 'ftp', 'mailto', 'file'):
         return None
 
     # Upstream code scans path, parameters, and query for colon characters
@@ -940,12 +940,13 @@ def extendMarkdown(self, md, md_globals):
                     %s           # zero-to-6 sets of paired parens
                 )?)              # Path is optional
                 | (?:[\w.-]+\@[\w.-]+\.[\w]+) # Email is separate, since it can't have a path
+                %s               # File path start with file:///, enable by setting ENABLE_FILE_LINKS=True
             )
             (?=                            # URL must be followed by (not included in group)
                 [!:;\?\),\.\'\"\>]*         # Optional punctuation characters
                 (?:\Z|\s)                  # followed by whitespace or end of string
             )
-            """ % (tlds, nested_paren_chunk)
+            """ % (tlds, nested_paren_chunk, r"| (?:file://(/[^/ ]*)+/?)" if settings.ENABLE_FILE_LINKS else r"")
         md.inlinePatterns.add('autolink', AutoLink(link_regex), '>link')
 
         md.preprocessors.add('hanging_ulists',

zerver/models.py

@@ -999,7 +999,7 @@ def content_has_image(content):
 
     @staticmethod
     def content_has_link(content):
-        return 'http://' in content or 'https://' in content or '/user_uploads' in content
+        return 'http://' in content or 'https://' in content or '/user_uploads' in content or 'file:///' in content
 
     def update_calculated_fields(self):
         # TODO: rendered_content could also be considered a calculated field

zerver/test_bugdown.py

@@ -175,6 +175,11 @@ def replaced(payload, url, phrase=''):
             converted = bugdown_convert(inline_url)
             self.assertEqual(match, converted)
 
+    def test_inline_file(self):
+        msg = 'Check out this file file:///Volumes/myserver/Users/Shared/pi.py'
+        converted = bugdown_convert(msg)
+        self.assertEqual(converted, '<p>Check out this file <a href="file:///Volumes/myserver/Users/Shared/pi.py" target="_blank" title="file:///Volumes/myserver/Users/Shared/pi.py">file:///Volumes/myserver/Users/Shared/pi.py</a></p>')
+
     def test_inline_youtube(self):
         msg = 'Check out the debate: http://www.youtube.com/watch?v=hx1mjT73xYE'
         converted = bugdown_convert(msg)

zproject/local_settings_template.py

@@ -112,6 +112,10 @@
 # a link to an image is referenced in a message.
 INLINE_IMAGE_PREVIEW = True
 
+# Controls whether or not Zulip will parse links starting with
+# "file:///" as a hyperlink.
+ENABLE_FILE_LINKS = False
+
 # By default, files uploaded by users and user avatars are stored
 # directly on the Zulip server.  If file storage in Amazon S3 is
 # desired, you can configure that as follows:

zproject/settings.py

@@ -159,6 +159,7 @@ def get_secret(key):
                     'REMOTE_POSTGRES_SSLMODE': '',
                     'GOOGLE_CLIENT_ID': '',
                     'DBX_APNS_CERT_FILE': None,
+                    'ENABLE_FILE_LINKS' : False,
                     }
 
 for setting_name, setting_val in DEFAULT_SETTINGS.iteritems():

zproject/test_settings.py

@@ -51,6 +51,9 @@
     }
 }
 
+# Enable file:/// hyperlink for test
+ENABLE_FILE_LINKS = True
+
 LOGGING['loggers']['zulip.requests']['level'] = 'CRITICAL'
 LOGGING['loggers']['zulip.management']['level'] = 'CRITICAL'