webpack: Migrate translations.js to use ES2015 syntax.

[digi0ps]

• Changed all the require statements to import statements.
• Removed IIFE wrapper

A part of the PR #5377.
@pweaver

[smarx]

Automated message from Dropbox CLA bot

@digi0ps, it looks like you've already signed the Dropbox CLA. Thanks!

[pweaver]

Thanks @digi0ps. One more change to clear up the way we handle adding globals to the app. It is probably better if long term we expose globals in one place. Also be setting i18next as the default export, it will make it easier to migrate other files which use the global.

[pweaver]

I think this would be more clear if this gets exported as the default export and exposed using expose-loader in webpack. That way a random file isn't exporting a global variable like this.

[pweaver]

It was pointed out that webpack doesn't support transpiling anything other then import/export statements. const declarations won't work in some browsers. It may be wise to change those to var or just migrate this module to typescript.

[codecov-io]

Codecov Report

Merging #5430 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5430   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         432      432           
  Lines       53565    53565           
  Branches     2092     2092           
=======================================
  Hits        46411    46411           
  Misses       7154     7154

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61744a7...02e0ce1. Read the comment docs.

[showell]

For future stuff like this, is it possible to do a whitespace-only change first to make it easier to review and be assured that nothing accidentally changed? Merging now.

[digi0ps]

I don't get you @showell?

[lonerz]

@digi0ps what he means is, make the whitespace changes in a separate commit

[digi0ps]

Whitespace changes as in? As far as I know whitespace changes are those stray whitespaces that come into the commit.

[lonerz]

Not sure, I just took what Steve said literally

[pweaver]

If you look at the commit since the outer function boundary was removed, the entire commit was unindented. This makes it very hard to diff what part of the function was changed vs just unindented. If you do the unindent in a separate function Steve can review the changes separately from the whitespace removal.

[showell]

Exactly. Thanks for the clear explanation, @pweaver.

[digi0ps]

Okay will do, thanks @pweaver.