Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Add service_identity to scrapy.txt. #5465

Merged
merged 1 commit into from Jun 19, 2017

Conversation

hackerkid
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 19, 2017

Codecov Report

Merging #5465 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   86.55%   86.51%   -0.04%     
==========================================
  Files         430      430              
  Lines       53043    53043              
  Branches     2066     2066              
==========================================
- Hits        45912    45891      -21     
- Misses       7131     7152      +21
Impacted Files Coverage Δ
zerver/tornado/ioloop_logging.py 46.66% <0%> (-46.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d06a28...a8a97ee. Read the comment docs.

@showell showell merged commit 61e74be into zulip:master Jun 19, 2017
@showell
Copy link
Contributor

showell commented Jun 19, 2017

merged, thanks @hackerkid!

@timabbott
Copy link
Sponsor Member

@hackerkid what does this do? In the future, please provide more detail in the rest of a commit message explaining the purpose of changes.

@showell
Copy link
Contributor

showell commented Jun 27, 2017

Just to provide some context, this was sort of an emergency fix, but, yeah, we probably should have put more detail in the commit message, and I should have asked for more detail before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants