api: Return anchor in get_messages when use_first_unread_anchor=True #8373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/server-api members, this pull request was labeled with the area: api label, so you may want to check it out! |
timabbott
reviewed
Feb 14, 2018
zerver/tests/test_narrow.py
Outdated
| self.login(self.example_email("hamlet")) | ||
| result = self.get_and_check_messages(dict(use_first_unread_anchor='true')) | ||
| self.assertIn("anchor", result) | ||
|
|
There was a problem hiding this comment.
I'd probably just add the assert to an existing test for use_first_unread_anchor.
timabbott
reviewed
Feb 14, 2018
zerver/lib/test_classes.py
Outdated
| "use_first_unread_anchor": ujson.dumps(use_first_unread_anchor)} | ||
| result = self.client_get("/json/messages", dict(post_params)) | ||
| data = result.json() | ||
| return data |
There was a problem hiding this comment.
Let's not duplicate the code from get_messages; we should just have get_messages be a wrapper for this that just returns the messages part.
|
Generally looks good @shubham-padia! I posted a few comments. |
shubham-padia
force-pushed
the
anchor
branch
5 times, most recently
from
1dc167a
to
bcc71b8
Compare
|
@timabbott I've made the changes |
|
@timabbott Please review |
|
Looks great, merged as a4b6862 after expanding the commit message to better explain the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6244
@timabbott Please review