uploads: Convert CMYK to RGB when saving avatar/realm icon as png. #8559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: S
area: dependencies
area: uploads
bug
and removed
area: dependencies
area: uploads
bug
labels
|
Hello @zulip/server-dependencies, @zulip/server-misc members, this pull request was labeled with the area: dependencies, area: uploads labels, so you may want to check it out! |
Fixes zulip#8546. PNG does not support CMYK mode. CMYK file is converted to RGB and then saved as PNG.
|
Nice, merged, thanks @shubham-padia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8546.
PNG does not support CMYK mode. CMYK file is converted to RGB and
then saved as PNG.
see: python-pillow/Pillow#1380
The file used for testing is obtained from wikipedia, so there are no copyright concerns.I tried converting the zulip logo used in test images, but converting to CMYK increases the image size by a lot ( >2MB ), i tried many solutions (using ImageMagick and Gimp) but couldn't reduce the size of the converted file.
Converted the zulip logo to cmyk with ImageMagick 馃帀
@timabbott Please review.