settings: Auto save user group members on blur. #8716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto saves group members if focus moves from the input field in the pill container.
Add do_not_blur func to not save changes when blur event's origin is one of name/description/pill input from the current user group. Changes in any of name/desc/members are saved together on blur from any of the input field given do_not_blur is false.
Also replaces trash icon with "Delete" for the button.
Clicking the cancel button removes all the changes and the user group returns back to the original state. Saved button is showed once the changes are saved on blur.
|
Hello @zulip/server-settings members, this pull request was labeled with the area: settings (admin/org) label, so you may want to check it out! |
shubham-padia
force-pushed
the
saveonblur5
branch
from
e641f8c
to
3058fdd
Compare
shubham-padia
commented
Mar 15, 2018
| assert.equal(group_description, 'uranohoshi — Students at Uranohoshi Academy'); | ||
| assert.equal(group_name_pills, 'uranohoshi'); | ||
| assert.equal(group_name_display, 'uranohoshi'); | ||
| assert.equal(group_description, 'Students at Uranohoshi Academy'); |
There was a problem hiding this comment.
Earlier the entire h4 row was being checked. Changing the delete user group button from trash icon to Delete string resulted in:
assert.equal(group_description, 'uranohoshi — Students at Uranohoshi Academy translated: Delete');Do let me know if this change needs to be reverted
There was a problem hiding this comment.
This seems totally fine.
|
@timabbott @rishig Please review. |
|
This is excellent work @shubham-padia! Merged. It's rare to see such a large change that I don't have anything to complain about :) |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8088.
any input that is not present in the current group, then that change is saved before allowing the user to edit the second group.
Changes saved if any other user group input clicked:
