org settings: De-duplicate template content for checkboxes. #8909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(It is a preliminary change for deduplication of org settings template.) This is done because of some settings like organization-settings has ids which match the pattern of having a prefix `id_` before the property name. For those settings which don't have any prefix, there will be no effect. Here obsolete `t` in the label is removed since we do label translations in JS files.
(It is a preliminary change for deduplication of org settings template.) This adds org settings labels as a context to admin templates so that they can be used as a context variables in admin templates. The reason we did this in JS code because of translation issue when passed (as a context in `partial` handlebars helper) directly within template.
|
Looks great, merged, thanks @shubhamdhama! I think we probably will want to do a further refactor to get rid of the |
|
I can include this as a followup if we really want to do this. |
|
Yeah, I think it's a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin.jssettings_checkbox.handlebarsby usingend_contentbut because of translation strings liketitlemakes it difficult to do so, e.g.id_realm_allow_message_deleting.