[WIP] Import script: Fixes. #8943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheaparekh
commented
Apr 4, 2018
| @@ -1747,6 +1748,7 @@ def import_attachments(data: TableData) -> None: | |||
| parent_id = 'attachment_id' | |||
| child_id = 'message_id' | |||
|
|
|||
| update_model_ids(parent_model, data, parent_db_table_name, 'attachment') | |||
rheaparekh
commented
Apr 4, 2018
| because of the difference in data format (TableData corresponding to realm data tables | ||
| and List[Record] corresponding to the avatar and attachment records) | ||
| """ | ||
| re_map_foreign_keys_internal(data[table], table, field_name, related_table, verbose, id_field, |
There was a problem hiding this comment.
I have used the wrapper function logic here mentioned in the review of the PR #8683. Sorry for missing this one!
rheaparekh
force-pushed
the
import
branch
3 times, most recently
from
d426cb3
to
c76863f
Compare
The message content is parsed for attachments, and the urls are updated corresponding to the newly allocated ids. Fixes zulip#8926
|
I verified this fixing the attachment links; opened #8949 for an issue that appears to have been created here. |
|
Merged, thanks @rheaparekh! I confirmed the attachments now work correctly. (Forgot to finish merging last night). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes followup from #8683 and fix for issue #8926.
Next followup: Huddle logic, RealmAuditLog