Slack import: update docs and add a comment. #9110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size information of an avatar is not required during the import. Check function 'import_uploads_local' and 'import_uploads_s3' in 'export.py' for this.
|
@rheaparekh do we need the |
|
I merged the comment commit, after a small tweak. Closing under the assumption that we don't need the other commit. Thanks @rheaparekh! |
|
@timabbott I thought it would be better if the users knew about threads, but you are correct, this should only be kept for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs about the threading method for downloads added in #9097.
Also, Add comment about the size information of avatars (Discussion in #9097)