New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notifications: Add stream email notifications. #9181
notifications: Add stream email notifications. #9181
Conversation
6f89657
to
d460a4a
Compare
@shubhamdhama can you rebase this? It's like 1000 commits behind master :) |
d460a4a
to
31d480f
Compare
@timabbott Resolved conflicts, though I'm not completely familiar with changes to how to test whether it does its job properly or not? |
8eff499
to
b3b55bb
Compare
FYI @shubhamdhama and I chatted about how to test this, and he's going to work on that today and ask questions on chat if any come up. |
@shubhamdhama do you have an update on the status of the work you and Steve discussed? Maybe something for us to chat about in person at the retreat tomorrow. |
I'm guessing this just kinda got lost in the shuffle. My advice is for Tim to just look over the shoulder of @shubhamdhama as he manually tests this, just to make sure all the new email niceness we have in dev works as advertised and to give any handy tips for manual testing in general. |
Sure we can discuss this tommorow!! BTW here is the link to the screenshots of the mails: https://chat.zulip.org/#narrow/stream/6-frontend/subject/testing.20emails/near/609440 |
Refactor to include triggers on messages, differentiating between mentions and stream message notifications.
b3b55bb
to
ecbeedb
Compare
@shubhamdhama and I did a rebase/split of this into a longer commit series, fixing a few bugs and several more things that were confusing about this PR. I then merged this as the commit series ending with de2ec8a. Huge thanks to @sarahcstringer and @shubhamdhama for all their work on this!!! Here are a couple follow-up projects we should probably do:
|
This test refactor makes the subscription/stream settings changes use standard APIs and thus be easier to follow (and more robust to subtle re-fetching bugs). This is a follow-up to #9181.
This test refactor makes the subscription/stream settings changes use standard APIs and thus be easier to follow (and more robust to subtle re-fetching bugs). This is a follow-up to zulip#9181.
This completes #7788.
@timabbott FYI.
I've fixed some minor and major merge conflicts so it's better to see a diff between original and these commits.