Added MyPy types to zilencer/views.py #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @pxhanus, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here. |
| @@ -18,11 +20,15 @@ | |||
| from django.conf import settings | |||
| import time | |||
|
|
|||
| from typing import Dict, Optional, Any | |||
|
|
|||
There was a problem hiding this comment.
remove one of these blank lines
|
I posted a few comments @pxhanus, otherwise this looks great! Let me know when you've pushed a revised version correctly those little issues. |
|
@timabbott, just updated the branch with your comments. |
|
Automated message from Dropbox CLA bot @pxhanus, thanks for signing the CLA! |
|
Looks like you mispelled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.