Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom fields: Add UI for custom field hint. #9266

Closed
wants to merge 1 commit into from

Conversation

YJDave
Copy link
Collaborator

@YJDave YJDave commented Apr 30, 2018

Fixes #8876

Current UI is:
customfieldhint

@rishig Does this UI make sense for custom field's hint?

@rishig
Copy link
Member

rishig commented Apr 30, 2018

I think putting it in small type below the box could work, similar to
image

@YJDave
Copy link
Collaborator Author

YJDave commented Apr 30, 2018

customfieldhint2
allcustomfieldhint
Thanks for quick response! Updated.

@timabbott
Copy link
Sponsor Member

Nice, merged, thanks @YJDave! One thing I notice very clearly on looking at this is that we need to fix the choice field type to be displayed as a dropdown; I guess we didn't get around to doing that yet :).

@timabbott timabbott closed this Apr 30, 2018
@YJDave YJDave deleted the field_hint branch April 30, 2018 17:19
@YJDave
Copy link
Collaborator Author

YJDave commented Apr 30, 2018

Yes, choice field is broken in profile settings. I was assuming that it is something @umairwaheed will be working on. @umairwaheed If you were not, let me know I will fix that :)

@timabbott
Copy link
Sponsor Member

I think you should just take this one, since he hasn't worked on that UI page and you have more time these days than he does :)

@YJDave
Copy link
Collaborator Author

YJDave commented Apr 30, 2018

Cool, I will submit the fix soon. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants