custom fields: Add UI for choice fields. #9322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks @YJDave! I also added 384a8f2 on top to make this use more standard ways of storing and accessing data from the templates. I noticed when playing around with the admin UI for creating choice fields that the "+" and "trash can" behavior for managing them is pretty busted; and also it's a bit weird that we ask users for a "value" in addition to the "Text" here: (I think we probably actually just want to use a numeric ID for the choice instead of a "value", since the value never appears anywhere anyway) Other than those things, the choice field type should be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIFs or Screenshots:
Part of issue #8878, followup of PR #9024