Add type annotations #938
Closed
Add type annotations #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @hyunchel, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here. |
|
Signed, thanks! |
|
Automated message from Dropbox CLA bot @hyunchel, thanks for signing the CLA! |
| @@ -43,6 +46,7 @@ def fix_row(row): | |||
| return content | |||
|
|
|||
| def dictfetchall(cursor): | |||
| # type: (Any) -> List[Dict[str, Any]] | |||
There was a problem hiding this comment.
I think cursor is of type connection.cursor
|
@hyunchel I posted some comments on how to make the types more precise. |
Type of parameter for function `is_recent`(line no.812) is `datetime`. MyPy errors out, however, when the parameter is defined as `datetime`. To get around, type `Any` is used.
hyunchel
force-pushed
the
type-annotation/analytics-views
branch
from
6120396
to
a84fae2
Compare
|
@timabbott Changes based on your review are applied and force pushed. |
|
Type check for (line no.819) |
|
Merged, thanks @hyunchel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of parameter for function
is_recent(line no.812) isdatetime.MyPy errors out, however, when the parameter is defined as
datetime.To get around, type
Anyis used.